refactor(safe-outputs): rename upload-attachment to upload-workitem-attachment#372
Merged
Merged
Conversation
…ttachment Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/b64aa169-a63c-4ed7-8d1a-7e1b6e53c26c Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesadevine
May 1, 2026 11:02
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the
upload-attachmentsafe-output tool toupload-workitem-attachmentto make the target (an ADO work item) explicit at the call site and leave room for other attachment surfaces (e.g. PRs, wiki) in future.upload-attachment→upload-workitem-attachment(MCP tool name, Stage 3 dispatch key,ToolResult::NAME,ctx.get_tool_config(...)key, front-mattersafe-outputs:key).UploadAttachmentParams/Result/Config→UploadWorkitemAttachment*; modulesrc/safeoutputs/upload_attachment.rs→upload_workitem_attachment.rs(re-exported throughsafeoutputs/mod.rs).README.md,AGENTS.md,docs/safe-outputs.md, bothprompts/*-ado-agentic-workflow.md, and.github/workflows/red-team-security.mdupdated to the new name.This is a breaking rename for any agent front matter referencing
upload-attachment:— there is no compatibility alias.Test plan
cargo build,cargo test(1049 passed),cargo clippy --all-targets --all-features— all green.